Merged
Conversation
dajimenezriv-internxt
requested review from
ArceDanielShok and
cg27shokworks
and removed request for
ArceDanielShok
ArceDanielShok
approved these changes
Jan 27, 2025
Contributor
ArceDanielShok
left a comment
ArceDanielShok
left a comment
There was a problem hiding this comment.
I like the idea of the GitHub action to avoid modifying the yarn files
cg27shokworks
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves a typo from a previous PR and also creates a github action that for now just checks "yarn tsc" so this cannot happen again. I will add in the future the job for running tests.